Skip to content

Commit

Permalink
remove some comments and add a const.
Browse files Browse the repository at this point in the history
  • Loading branch information
nithyatsu committed Jan 8, 2025
1 parent 1469009 commit c6eb041
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion pkg/cli/cmd/resourceprovider/create/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ func (r *Runner) Run(ctx context.Context) error {
return err
}

// Add a blank line before printing the result.
r.Output.LogInfo("")

err = r.Output.WriteFormatted(r.Format, response, common.GetResourceProviderTableFormat())
Expand Down
1 change: 0 additions & 1 deletion pkg/cli/cmd/resourcetype/create/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ func (r *Runner) Run(ctx context.Context) error {
}
}

// Add a blank line before printing the result.
r.Output.LogInfo("")

err = r.Output.WriteFormatted(r.Format, response, common.GetResourceTypeTableFormat())
Expand Down
2 changes: 1 addition & 1 deletion pkg/cli/manifest/registermanifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func RegisterType(ctx context.Context, clientFactory *v20231001preview.ClientFac

var defaultAPIVersion string
if resourceType.DefaultAPIVersion == nil {
defaultAPIVersion = "2023-10-01-preview" //hardcoded for now, since we don't have a default API version in the manifest but it should be made mandatory as part of schema validation
defaultAPIVersion = v20231001preview.Version //hardcoded for now, since we don't have a default API version in the manifest but it should be made mandatory as part of schema validation
} else {
defaultAPIVersion = *resourceType.DefaultAPIVersion
}
Expand Down

0 comments on commit c6eb041

Please sign in to comment.