Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws generator to use bicep-types and new contract #40

Merged

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Apr 15, 2024

Update aws generator to use bicep-types and new contract

@sk593 sk593 changed the base branch from main to feature-bicep-compiler-merge April 15, 2024 20:23
@sk593
Copy link
Contributor Author

sk593 commented Apr 15, 2024

Will add the updated generated files once the PR has been reviewed. There's ~1000 generated files so it's a little hard to review the PR with them added :)

@sk593 sk593 force-pushed the update-bicep-types-aws branch from 8abcfbc to c2f2bcf Compare April 25, 2024 22:34
Copy link
Contributor

@willdavsmith willdavsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a comment explaining how you tested these changes?

@sk593
Copy link
Contributor Author

sk593 commented Jun 4, 2024

Can you write a comment explaining how you tested these changes?

convert.test.ts has unit tests for the generator. So it checks the generated types against what is expected out of it

@sk593 sk593 force-pushed the update-bicep-types-aws branch from 23d462b to 626f1fc Compare June 24, 2024 20:22
@sk593 sk593 force-pushed the update-bicep-types-aws branch from 626f1fc to cfa8bd9 Compare June 24, 2024 20:26
@sk593 sk593 merged commit 7646c2d into radius-project:feature-bicep-compiler-merge Jun 24, 2024
1 of 2 checks passed
sk593 added a commit that referenced this pull request Jul 1, 2024
* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Jul 2, 2024
* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Jul 2, 2024
* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Jul 2, 2024
* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Aug 6, 2024
* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request Aug 6, 2024
* Update aws generator to use bicep-types and new contract (#40)

* updating aws generator to use bicep-types and new contract

---------
Signed-off-by: sk593 <[email protected]>

* Update build and publish workflow bicep (#45)

* update workflows

---------

Signed-off-by: sk593 <[email protected]>

* Update publish trigger during releases (#47)

* update to trigger workflow on release

Signed-off-by: sk593 <[email protected]>

* update to push to acr on tag creation

Signed-off-by: sk593 <[email protected]>

* update workflow

Signed-off-by: sk593 <[email protected]>

---------

Signed-off-by: sk593 <[email protected]>

---------

Signed-off-by: sk593 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants