Feature/sample sheet support #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavlemarinkovic
commented
Jan 29, 2024
pavlemarinkovic
commented
- Added support for autogenerating sample sheet function(s) for Nextflow app wrapper.
- sbpack will now avoid overwriting previous version of sb_nextflow_schema.yaml
- Enums will be better parsed and generated
- New --auto mode tries to locate as many files and inputs for generating the app automatically
- The logic for uploading the app code package and the app itself has been updated. It now first tires to create the app wrapper, and if it succeeds then tries to upload the code package.
Add sample sheet parsing dump_sb_wrapper does not overwrite previous versions of the sb_nextflow_schema
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums Add --auto mode Cleanup First try to make app wrapper, then try to upload, instead of the other way around
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums Add --auto mode Cleanup First try to make app wrapper, then try to upload, instead of the other way around Give warning if detected version is not matching provided
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums Add --auto mode Cleanup First try to make app wrapper, then try to upload, instead of the other way around Give warning if detected version is not matching provided Profile is not required
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums Add --auto mode Cleanup First try to make app wrapper, then try to upload, instead of the other way around Give warning if detected version is not matching provided Profile is not required pep8 pack appid not required if dump-sb-app is used
pavlemarinkovic
requested review from
borislavd88
and removed request for
bosonogi
borislavd88
reviewed
Jan 30, 2024
Add method to get templates Add Wrapper class to store app wrapper (wrapper.py) Support enums Add --auto mode Cleanup First try to make app wrapper, then try to upload, instead of the other way around Give warning if detected version is not matching provided Profile is not required pep8 pack appid not required if dump-sb-app is used
borislavd88
reviewed
Jan 30, 2024
borislavd88
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.