GitHub Actions: Replace workflows by a single one #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes the build of the docs with Erlang/OTP 27.1.
[Why] Before, we had the following workflows: * one to test Horus * one to generage and publish docs * one to publish a release to Hex.pm One problem was that the docs and the release workflows didn't depend on the test results. Another one was that the docs was only built for the main branch before the publish. So if a pull request broke the docs, we would not notice it before the breakage was in main. [How] The new workflow was copied from Khepri where the initial work happened. All workflows are combined into a single workflow with the correct dependencies. Also, the docs are always generated regardless of the branch and published only it is main.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 86.63% 84.41% -2.23%
==========================================
Files 3 3
Lines 943 943
==========================================
- Hits 817 796 -21
- Misses 126 147 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Before, we had the following workflows:
One problem was that the docs and the release workflows didn't depend on the test results.
Another one was that the docs was only built for the main branch before the publish. So if a pull request broke the docs, we would not notice it before the breakage was in main.
How
The new workflow was copied from Khepri where the initial work happened. All workflows are combined into a single workflow with the correct dependencies.
Also, the docs are always generated regardless of the branch and published only it is main.