test/cached_extractions.erl: Ignore compile:forms/2-related Dialyzer errors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors [Why] What I considered a fix to the `compile:forms/2` function was accepted in erlang/otp#5293 and available in Erlang/OTP 25.0+. However, this change was reverted in Erlang/OTP 27.0. I don't know the reason as of this writing. Dialyzer in Erlang/OTP 27.0 also improved and now, it is not pleased by the way we use `compile:forms/2`, directly passing assembler. [How] Let's ignore this Dialyzer error, like we ignore it already in `horus`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 86.61% 86.61%
=======================================
Files 3 3
Lines 934 934
=======================================
Hits 809 809
Misses 125 125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What I considered a fix to the
compile:forms/2function was accepted in erlang/otp#5293 and available in Erlang/OTP 25.0+. However, this change was reverted in Erlang/OTP 27.0. I don't know the reason as of this writing.Dialyzer in Erlang/OTP 27.0 also improved and now, it is not pleased by the way we use
compile:forms/2, directly passing assembler.How
Let's ignore this Dialyzer error, like we ignore it already in
horus.