Redirect $(WASM)/lib/R/bin JS binaries to use native R
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binaries built by Emscripten in $(WASM)/lib/R/bin are JavaScript output, unable to be run directly by the host machine. Such binaries can be run using Node, but require some further setup (e.g. relocation of the required `R.wasm` file). Since these scrips do not work, Makevars targets relying on executing R code using `$(R_HOME)/bin/R` fail. The `symbols.rds` target in `lib/share/make/shlib.mk` is an example. With this commit, these specific scripts are redirected to use the version of R compiled for the host machine, working around the issue.
georgestagg
added a commit
that referenced
this pull request
Mar 13, 2024
Follow-up to #367. Redirecting the wasm R and Rscript to the host binaries works, but R_HOME is no longer as expected. A warning about this is printed to `stdout`, breaking subcommands and pipes when cross-compiling R packages that run R or Rscript in e.g. Makevars. This change redirects that warning to `stderr`. See also https://bugs.r-project.org/show_bug.cgi?id=15070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaries built by Emscripten in
$(WASM)/lib/R/binare JavaScript output, unable to be run directly by the host machine. Such binaries can be run using Node, but require some further setup (e.g. relocation of the requiredR.wasmfile).Since these scripts do not work when executed directly,
Makevarstargets relying on running R code using$(R_HOME)/bin/Rfail. Thesymbols.rdstarget inlib/share/make/shlib.mkis an example of this issue.With this commit, these specific scripts are redirected to use the version of R compiled for the host machine, working around the problem.
This should hopefully fix r-wasm/rwasm#13.