Skip to content

Commit

Permalink
NEWS and CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed May 26, 2024
1 parent 179b6a1 commit 816a3da
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 30 deletions.
22 changes: 1 addition & 21 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# RPostgres 1.4.7 (2024-05-26)

## Breaking changes
## Features

- Breaking change: Avoid appending a numeric suffix to duplicate column names (#463).

Expand All @@ -11,42 +11,22 @@
- `dbWriteTable()` correctly handles name clashes between temporary and permanent tables (#402, #431).
- Fix `dbQuoteIdentifier()` for `Id()` objects to no longer rely on names (#460).

## Features

- Breaking change: Avoid appending a numeric suffix to duplicate column names (#463).

## Chore

- Bump preferred libpq version on MacOS to 15 (#441, #465).
- Refactor `dbListTables()` et al. (@dpprdan, #413).
- Refactor `list_fields()` (#462).
- Use `Id` in `exists_table()` (#461).
- Add Aviator configuration.
- Define build-time dependencies.
- Use cache-from to control ghcr cache.
- Improve ghcr workflow.
- Fix docker-compose file.
- Fix typo in `configure`.
- Add Docker setup.
- Fix warning on Windows (#449).

## Documentation

- Set BS version explicitly for now (@maelle, #464).
- Use dbitemplate (@maelle, #456).
- Typo r-lib -\> r-dbi (@dpprdan, #454).
- No more Rcpp in DESCRIPTION (#446).

## Testing

- Test for columns in `dbQuoteIdentifier()` (@dpprdan, #263, #372).
- Fix tests if DBItest is not installed (#448).

## Uncategorized

- Internal changes only.
- Merge branch 'cran-1.4.6'.


# RPostgres 1.4.6 (2023-10-22)

Expand Down
11 changes: 2 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,12 @@ RPostgres 1.4.7
## Current CRAN check results

- [x] Checked on 2024-05-26, problems found: https://cran.r-project.org/web/checks/check_results_RPostgres.html
- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc
- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64
File ‘RPostgres/libs/RPostgres.so’:
Found non-API calls to R: ‘SETLENGTH’, ‘SET_TRUELENGTH’

Compiled code should not call non-API entry points in R.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.
- [ ] NOTE: r-devel-windows-x86_64
File 'RPostgres/libs/x64/RPostgres.dll':
Found non-API calls to R: 'SETLENGTH', 'SET_TRUELENGTH'

Compiled code should not call non-API entry points in R.

See 'Writing portable packages' in the 'Writing R Extensions' manual.

Check results at: https://cran.r-project.org/web/checks/check_results_RPostgres.html
Upstream problem, can't fix.

0 comments on commit 816a3da

Please sign in to comment.