Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measurement builder #879

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

shumpohl
Copy link
Member

@shumpohl shumpohl commented Jan 4, 2025

First version of a measurement builder. It produces a sequence of wait, measure and loop commands that can easily be translated into arbitrary formats. There is a translation to the currently used (begin, length) table in ``to_table`.

Following thigs are to note:

  • The commands support HardwareTime arguments which is not implemented by any measurement device afaik but could be.
  • The commands allow negative delays to make time inversion easy. This makes consuming the commands harder because all previous measurement times could be needed.
  • The table conversion with the python "VM" is rather slow

Remaining tasks:

  • Doc strings in the code
  • Make measurement window handling in the pulse templates more lenient.
    • Allow windows that leave the PT
    • Allow symbolic windows
  • Add tests for repetitions
  • Add tests for nested iterations
  • Add tests for time reversal
  • Example usage with MeasurementBuilder and to_table
  • Add a normalization function that gets rid of negative delays

Nice to haves:

  • Data analysis that uses the commands. Maybe it can be integrated in atssimple @maxbeer99 ?
  • Speed up table translation with numba

Copy link

github-actions bot commented Jan 4, 2025

Test Results

1 199 tests   1 131 ✅  1m 9s ⏱️
    1 suites     61 💤
    1 files        7 ❌

For more details on these failures, see this check.

Results for commit db5ffbc.

♻️ This comment has been updated with latest results.

@shumpohl shumpohl force-pushed the issues/871_measurement_builder branch from bd41e25 to d48aa2b Compare January 23, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant