Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Join rule event #862

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Join rule event #862

wants to merge 4 commits into from

Conversation

nvrWhere
Copy link
Collaborator

Upstream join rule event from neochat

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nvrWhere nvrWhere requested a review from KitsuneRal January 26, 2025 17:07
KitsuneRal
KitsuneRal requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM except a couple of technical things.

Quotient/events/roomjoinrulesevent.h Outdated Show resolved Hide resolved
Quotient/events/roomjoinrulesevent.h Outdated Show resolved Hide resolved
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Feb 3, 2025
@nvrWhere nvrWhere requested a review from KitsuneRal February 9, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal Awaiting requested review from KitsuneRal

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: In work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvrWhere @KitsuneRal