Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History change #219

Closed
wants to merge 9 commits into from
Closed

History change #219

wants to merge 9 commits into from

Conversation

Deokumarjnu
Copy link
Contributor

@Deokumarjnu Deokumarjnu commented Mar 30, 2021

Description

Added support for the new version of the history package i.e - 5.x.x.

Fixes # #220 and https://github.com/quintype/ace-planning/issues/157

Dependencies # NA

Documentation # NA

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally with the beta version

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Jeevan-Kishore
Copy link
Contributor

"history": "^4.9.0", is mentioned on react-router, this might break.

Rejecting PR

@Jeevan-Kishore
Copy link
Contributor

"history": "^4.9.0", is mentioned on react-router, this might break.
Rejecting PR

@Deokumarjnu Deokumarjnu deleted the history-change branch April 9, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants