Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions OAuth #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Versions OAuth #42

wants to merge 2 commits into from

Conversation

louispt1
Copy link
Collaborator

This PR:

  • Adjusts the engine and model clients to use the version tags to decide which engine/model to communicate with
  • Includes a 'current_version' method in the base controller which grabs the version out of the params (if possible) so it is accessible to other controllers.
  • Removes the trailing slash on the idp url in the local application config.
  • Refactors the version url generation slightly

@louispt1 louispt1 requested a review from noracato December 20, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noracato noracato Awaiting requested review from noracato

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louispt1 @noracato