-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset Province of Noord-Holland update to 2022 #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaskranenburgQ! I understand your wish for a more clear message and value your enthusiasm, but changes like these should come in a separate PR. Right now I don't have the time or insight to review your changes, and that is blocking the merge of the new data.
What would work best next time is to open an issue where we can discuss the actual need (maybe more messages can be clarified) and update the code in all places necessary when we address it in the sprint.
If you could remove the code in the importable_commit
and move it to an issue, that would be great!
@noracato Alright! Will do that. |
6960d0e
to
a3e5799
Compare
a3e5799
to
2776da9
Compare
With the removal of the changes for the file importable_commit.rb the migration will no longer run. |
Thanks to @louispt1 the issue is fixed! We can go ahead with the merge! |
This PR updates the province of Noord-Holland to 2022.
In this update we mostly took the 2019 dataset and updated the most notable changes in Klimaatmonitor. This effort is therefore useful for new studies with this dataset.
Goes together with: quintel/etsource#3135