Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration could return unreadable error messages #545

Open
kaskranenburgQ opened this issue Oct 14, 2024 · 3 comments
Open

Migration could return unreadable error messages #545

kaskranenburgQ opened this issue Oct 14, 2024 · 3 comments
Assignees
Labels

Comments

@kaskranenburgQ
Copy link
Contributor

kaskranenburgQ commented Oct 14, 2024

While running a migration I got the following error message:

Caused by:
NoMethodError: undefined method value' for nil:NilClass (NoMethodError)

        if value && value != current.find(key).value

Following this error message it was unclear where I had to fix this error message.
I could not deduce whether one of the given values, commit messages, or a combination of the two was not valid according to the migration.
While digging deeper I found that the importable_commit.rb file generated this error message, since I entered some keys in the migration that can not be altered.

I propose that we change the error message to one that is more descriptive, meaning that the error message tells you what keys you entered in the migration should be removed.

Notifying @noracato

@MartLubben
Copy link
Contributor

What is the status of this issue? Will it be solved before the start of the next month?

@noracato
Copy link
Member

@MartLubben It does not need to be solved to merge the PR with the data. We will pick this up at a later point!

Copy link

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants