Use the heartbeats shipped with the digest for cluster membership and failure detection #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
leverage-digest2
branch
3 times, most recently
from
f1fed82 to
ac02ca3
Compare
fulmicoton
changed the title
fulmicoton
force-pushed
the
leverage-digest2
branch
2 times, most recently
from
5cf109a to
adf1f46
Compare
fulmicoton
commented
Feb 19, 2024
fulmicoton
force-pushed
the
leverage-digest2
branch
2 times, most recently
from
7038731 to
f1d16cf
Compare
fmassot
reviewed
Feb 19, 2024
fmassot
reviewed
Feb 19, 2024
fmassot
approved these changes
Feb 19, 2024
fulmicoton
force-pushed
the
leverage-digest2
branch
from
f1d16cf to
87db745
Compare
Right now we send the heartbeat of all of the known nodes in the cluster during digests. We can use that information for cluster membership. This will allow nodes to detect new member, join a cluster, and detect failure considerably faster. This PR also removes heartbeat from delta message. Instead it joins the last_gc_version, to fix a bug introduced in #122. Bugfix: Avoid updating the time of death of a node when it is redetected as faulty. We remove outselves from the list of seeds. Before nodes were regularly gossipping with themselves. Code improvement: In the failure detector when we have few samples. We now use additive smoothing.
fulmicoton
force-pushed
the
leverage-digest2
branch
from
87db745 to
22c3f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.