Don't emit duplicate source locations #917
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires a little extra bookkeeping but there are two good reasons to accept that overhead:
OP_source_loc is pretty big at 9 bytes so duplicates bloat the bytecode considerably
An OP_source_loc opcode can throw off the peephole optimizer if it's between two opcodes the optimizer is trying to match; removing duplicates reduces the chance of that happening
Fixes: #916