Rename repolinter file #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Matyas <[email protected]>
Signed-off-by: Mark Matyas <[email protected]>
|
The action is from new relic, but the format is the upstream repolinter format.
Regards,
Craig
…________________________________
From: Mark Matyas ***@***.***>
Sent: Friday, May 28, 2021 11:00:24 AM
To: quic/license-text-normalizer-js ***@***.***>
Cc: quic_craign ***@***.***>; Mention ***@***.***>
Subject: [EXT] [quic/license-text-normalizer-js] Rename repolinter file (#17)
@craigez<https://github.com/craigez> the newrelic github action is still the one we should use. There is another one from Philips but it doesn't use the docker to install the 3rd party extensions like Ruby linguist, etc. See
newrelic/repolinter-action#10 (comment)<newrelic/repolinter-action#10 (comment)>
________________________________
You can view, comment on, or merge this pull request online at:
#17
Commit Summary
* Rename repolinter file
File Changes
* R .github/workflows/repolinter.yaml<https://github.com/quic/license-text-normalizer-js/pull/17/files#diff-7a81e0ae6ed5172b117b4c2602cdb6b985d4c166a1967017c4a09146358367fe> (4)
* R repolint.json<https://github.com/quic/license-text-normalizer-js/pull/17/files#diff-b48cf41cd1eb360ec410cb7d16fa16dd6c3a6088a2868b0cd138c3a2ea170e8c> (0)
Patch Links:
* https://github.com/quic/license-text-normalizer-js/pull/17.patch
* https://github.com/quic/license-text-normalizer-js/pull/17.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#17>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB6Q3NBDZMAJ6VXUXIJILGTTP7K3RANCNFSM45XFE5GQ>.
|
Rulesets are repolinter upstream format (looks like most of newrelic's fork was merged upstream). They have to update the action to use upstream to get very latest though as the action still points to the newrelic fork. Also ideally the action would move repolinter repo. So its fine for now, will keep an eye on that one issue though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@craigez the newrelic github action is still the one we should use. There is another one from Philips but it doesn't use the docker to install the 3rd party extensions like Ruby linguist, etc. See
newrelic/repolinter-action#10 (comment)