Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate QueueITLib to Swift #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexanderthoren
Copy link

@alexanderthoren alexanderthoren commented Dec 11, 2024

Why?

What does this PR do?

  • Migrates the project to Swift.

Changes

  • Modified .gitignore and Package.swift
  • Deleted old Objective-C files from QueueITLib
  • Added new Swift files to Sources/QueueITLib

Tech debt

  • Didn't add tests yet.
  • Didn't add protocols and injection.
  • Didn't migrate to async/await.
  • Didn't update the README.

Maybe I will take a look into these in the short future as I want to contribute to more open source projects.

- Modified .gitignore and Package.swift
- Deleted old Objective-C files from QueueITLib
- Added new Swift files to Sources/QueueITLib
Removed redundant return types from methods in QueueItEngine and
QueueITWaitingRoomProvider classes. This change simplifies the code
by eliminating unnecessary return statements.
Renamed various files and classes to improve naming consistency across
the project. Updated references in the README.md and source files to
reflect these changes. This includes renaming classes like
QueueITApiClient to ApiClient, QueueITWaitingRoomProvider to
WaitingRoomProvider, and others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant