Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception when parsing dates with no times #36

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Fix exception when parsing dates with no times #36

merged 1 commit into from
Dec 29, 2024

Conversation

valadaptive
Copy link
Contributor

Otherwise, parseInt throws because it is passed null.

Alternatively, we could throw a UserError if you want to just reject dates without times as invalid, instead of whatever parseInt throws that we don't catch.

@valadaptive
Fix exception when parsing dates with no times
e4b2623 
Otherwise, `parseInt` throws because it is passed `null`.
@valadaptive valadaptive requested a review from qixils December 29, 2024 05:43
@qixils qixils merged commit 4e27df2 into main Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qixils qixils Awaiting requested review from qixils

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valadaptive @qixils