Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.18] 3.18.3 backports 1 #46210

Merged
merged 26 commits into from
Feb 12, 2025
Merged

[3.18] 3.18.3 backports 1 #46210

merged 26 commits into from
Feb 12, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 11, 2025

Please don't merge, I will merge it myself.

Ladicek and others added 24 commits February 11, 2025 19:06
(cherry picked from commit 09a2733)
(cherry picked from commit be622b8)
This is definitely suboptimal and can lead to infinite loops.

Also made some other micro improvements.

(cherry picked from commit 80e4bc6)
So we need to handle it properly.

Spotted in: https://github.com/quarkiverse/quarkus-artemis/actions/runs/13150585162/job/36697206471

With stacktrace:
```
Error: ]: Build step io.quarkus.arc.deployment.ConfigBuildStep#validateConfigMappingsInjectionPoints threw an exception: java.lang.NullPointerException: Cannot invoke "org.jboss.jandex.AnnotationTarget.kind()" because "target" is null
	at io.quarkus.arc.deployment.ConfigBuildStep.validateConfigMappingsInjectionPoints(ConfigBuildStep.java:413)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
	at java.base/java.lang.Thread.run(Thread.java:1583)
	at org.jboss.threads.JBossThread.run(JBossThread.java:499)

	at io.quarkus.builder.Execution.run(Execution.java:122)
	at io.quarkus.builder.BuildExecutionBuilder.execute(BuildExecutionBuilder.java:78)
	at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:161)
	at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:350)
```

(cherry picked from commit 8c182c0)
(cherry picked from commit 3f0d8c5)
…y can be observed from a bean within given context

(cherry picked from commit 8336485)
We essentially use Class.forName to load the class instead of the
ClassLoader directly, as the former knows how to deal with arrays

Fixes: quarkusio#46170
(cherry picked from commit 909bf16)
I was hoping to constrain JUnit tests and @QuarkusComponentTests but
@QuarkusComponentTest is in another artifact so this will have to do.

Related to quarkusio#46035.

Note that you can still break things if you specify another priority but
that's how it is :).

(cherry picked from commit 3b89af2)
The ITs were run as part of the Surefire execution and apparently
something is leaking from them.
It wasn't an issue before because they were executed at the end of the
run but they were executed first with the new orderer given they are
not annotated with a Quarkus test annotation.

(cherry picked from commit 1abb1b9)
We already have the full path at some point so there's really no need to
rebuild it once again, especially since the code was incorrect as it was
adding the /q/ prefix always if it wasn't there in the path.

It's perfectly valid to not have /q in the path, for instance if you set
quarkus.smallrye-health.root-path to /something/else.

I added a new test based on the report in addition to the ones we added
recently for related fixes.

Fixes quarkusio#46040

(cherry picked from commit d8daa71)
Bumps [io.micrometer:micrometer-bom](https://github.com/micrometer-metrics/micrometer) from 1.14.3 to 1.14.4.
- [Release notes](https://github.com/micrometer-metrics/micrometer/releases)
- [Commits](micrometer-metrics/micrometer@v1.14.3...v1.14.4)

---
updated-dependencies:
- dependency-name: io.micrometer:micrometer-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit ffc972f)
… podman rootless. quarkusio#46190

Signed-off-by: cmoulliard <[email protected]>
(cherry picked from commit 5aa8f80)
Copy link

quarkus-bot bot commented Feb 11, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot changed the title 3.18.3 backports 1 [3.18] 3.18.3 backports 1 Feb 11, 2025
@gsmet gsmet self-assigned this Feb 11, 2025
@gsmet gsmet added the area/infra internal and infrastructure related issues label Feb 11, 2025
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config labels Feb 11, 2025
@quarkus-bot quarkus-bot bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/mailer area/oidc area/picocli area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/smallrye area/testing area/tracing area/vertx labels Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

Bumps [io.smallrye:jandex](https://github.com/smallrye/jandex) from 3.2.5 to 3.2.6.
- [Release notes](https://github.com/smallrye/jandex/releases)
- [Changelog](https://github.com/smallrye/jandex/blob/main/RELEASE_PROCEDURE.md)
- [Commits](smallrye/jandex@3.2.5...3.2.6)

---
updated-dependencies:
- dependency-name: io.smallrye:jandex
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 5d8df90)
Copy link

quarkus-bot bot commented Feb 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 90daf5c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Feb 12, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 90daf5c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit a92a24d into quarkusio:3.18 Feb 12, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/infra internal and infrastructure related issues area/mailer area/oidc area/picocli area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/rest area/smallrye area/testing area/tracing area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.