Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observability main page #46059

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Observability main page #46059

merged 1 commit into from
Feb 11, 2025

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Feb 4, 2025 •
edited
Loading

Fixes: #46061

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 4, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@brunobat brunobat self-assigned this Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot bot added the area/docstyle issues related for manual docstyle review label Feb 4, 2025
@brunobat brunobat marked this pull request as ready for review February 4, 2025 16:34
@brunobat
Copy link
Contributor Author

brunobat commented Feb 4, 2025

CC @kittylyst

@brunobat brunobat requested a review from ebullient February 4, 2025 16:37
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of suggestions.

Also there is a small conflict due to the deprecation of GELF.

docs/src/main/asciidoc/_includes/observability-include.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/observability.adoc Outdated Show resolved Hide resolved
@dmlloyd dmlloyd removed their request for review February 11, 2025 15:10
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 200b717.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 6c9870d into quarkusio:main Feb 11, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@chiroito chiroito Awaiting requested review from chiroito

@ebullient ebullient Awaiting requested review from ebullient

Assignees

@brunobat brunobat

Labels
area/docstyle issues related for manual docstyle review area/documentation area/logging area/metrics area/tracing
Projects
None yet
Milestone
3.19.0.CR1
Development

Successfully merging this pull request may close these issues.

Create an Observability documentation page
2 participants
@brunobat @gsmet