Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WebAuthn quickstart #1079

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Mar 15, 2022

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

This is draft, because the extention PR is currently not working: quarkusio/quarkus#24316

@FroMage
Copy link
Member Author

FroMage commented Apr 26, 2022

Rebased, but the native test doesn't work with Quarkus main ATM, working on a PR to fix this.

@FroMage
Copy link
Member Author

FroMage commented Apr 26, 2022

Here's the Quarkus PR: quarkusio/quarkus#25174

@FroMage FroMage marked this pull request as ready for review April 27, 2022 14:56
@FroMage
Copy link
Member Author

FroMage commented Apr 27, 2022

PR got merged, we're all good, though perhaps we need a review?

@FroMage FroMage requested a review from sberyozkin April 27, 2022 14:56
@@ -0,0 +1,103 @@
package org.acme.security.webauthn.test;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it is worth renaming RenardeCookieFilter to something more neutral in context of these tests as it can not be obvious to some users why it starts from Renarde ?
By the way ss far as Renarde is concerned, I think it would be good to have https://quarkus.io/version/main/guides/security-webauthn updated, its References section to link to Renarde as a concrete application which uses Quarkus WebAuthn

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FroMage It probably does not matter as it is a test specific resource only, we can merge as is

@sberyozkin sberyozkin self-requested a review April 28, 2022 16:08
@sberyozkin sberyozkin merged commit fd71962 into quarkusio:development Apr 28, 2022
@FroMage
Copy link
Member Author

FroMage commented Apr 29, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants