-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WebAuthn quickstart #1079
Conversation
Rebased, but the native test doesn't work with Quarkus |
Here's the Quarkus PR: quarkusio/quarkus#25174 |
PR got merged, we're all good, though perhaps we need a review? |
@@ -0,0 +1,103 @@ | |||
package org.acme.security.webauthn.test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it is worth renaming RenardeCookieFilter
to something more neutral in context of these tests as it can not be obvious to some users why it starts from Renarde
?
By the way ss far as Renarde is concerned, I think it would be good to have https://quarkus.io/version/main/guides/security-webauthn updated, its References
section to link to Renarde as a concrete application which uses Quarkus WebAuthn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FroMage It probably does not matter as it is a test specific resource only, we can merge as is
Thanks! |
Check list:
Your pull request:
development
branch999-SNAPSHOT
version of Quarkusmvn clean test
)mvn clean package -Pnative
)mvn clean verify -Pnative
)README.md
file (with build and run instructions)pom.xml
andREADME.md
This is draft, because the extention PR is currently not working: quarkusio/quarkus#24316