Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated CodeHaus container to Sisu container #25

Closed
wants to merge 2 commits into from

Conversation

michalvavrik
Copy link
Member

Summary

All CodeHaus Plexu containers projects has been deprecated and not updated for a while now https://codehaus-plexus.github.io/plexus-containers/. So migrating to recommended option. I set dependencies scope to provided as I saw in here: https://maven.apache.org/examples/maven-3-lifecycle-extensions.html

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/migrate-codehaus-to-sisu branch from 31fef15 to 9671a50 Compare September 25, 2024 13:00
@michalvavrik michalvavrik force-pushed the feature/migrate-codehaus-to-sisu branch from 9671a50 to 2f535ab Compare September 25, 2024 13:13
@michalvavrik
Copy link
Member Author

This seems to pass locally repeatedly but when run in CI plugin is not started. Don't have time to deal with it now, so making it draft.

@michalvavrik michalvavrik marked this pull request as draft September 25, 2024 13:33
@michalvavrik
Copy link
Member Author

I'll do it in another PR, ideally this week. Looking right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant