Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move third_party to recirq/third_party #361

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Move third_party to recirq/third_party #361

merged 12 commits into from
Jul 30, 2024

Conversation

fdmalone
Copy link
Collaborator

Should fix pip installation within notebooks.

@fdmalone fdmalone requested a review from dstrain115 July 29, 2024 18:56
@fdmalone fdmalone requested a review from pavoljuhas July 29, 2024 19:07
pavoljuhas
pavoljuhas suggested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small suggestions, but otherwise LGTM.

recirq/third_party/quaff/basis_change_test.py Outdated Show resolved Hide resolved
recirq/third_party/quaff/json_resolver.py Outdated Show resolved Hide resolved
recirq/third_party/quaff/json_resolver.py Outdated Show resolved Hide resolved
@pavoljuhas
Copy link
Contributor

One more comment - after merging with master the high_level.ipynb notebook fails when trying to read .../site-packages/recirq/qcqmc/data/integrals/fh_sto3g/hamiltonian.chk.

Perhaps that file needs to be added to package_data here?

ReCirq/setup.py

Lines 56 to 61 in 17a5fde

package_data={'recirq': [
# https://github.com/quantumlib/ReCirq/issues/101
'hfvqe/molecular_data/hydrogen_chains/*/*/*',
# Needed for ftbbl docs
'otoc/loschmidt/tilted_square_lattice/*',
]},

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@fdmalone
Copy link
Collaborator Author

@pavoljuhas PTAL I think I resolved everything and verified the notebooks run in a clean environment.

@fdmalone fdmalone merged commit 7f4119a into quantumlib:master Jul 30, 2024
5 checks passed
@fdmalone fdmalone deleted the move_quaff branch July 30, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdmalone @pavoljuhas