Avoid flaky test execution in z_phase_calibration_test #6928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove test dependence on the randomly-seed value by passing `random_state` argument to `calibrate_z_phases` and `z_phase_calibration_workflow`. Choose seed value from several trial runs with a faster fit convergence and shorter execution time. Related to quantumlib#6906
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6928 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1084 1084
Lines 94309 94315 +6
=======================================
+ Hits 92298 92305 +7
+ Misses 2011 2010 -1 ☔ View full report in Codecov by Sentry. |
mhucka
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove test dependence on the pytest randomly-seed value by passing
random_statetocalibrate_z_phasesandz_phase_calibration_workflow.Choose seed value from several trial runs with a faster fit convergence
and shorter execution time.
Related to #6906