Fix diagram for Identity with no qubits #6926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- An IdentityGate with 0 qubits used to raise an exception in the circuit drawer. - This PR fixes the issue and displays the gate similar to a GlobalPhaseGate. Fixes: quantumlib#6768
NoureldinYosri
approved these changes
Jan 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6926 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 1084 1084
Lines 94309 94314 +5
=======================================
+ Hits 92298 92303 +5
Misses 2011 2011 ☔ View full report in Codecov by Sentry. |
pavoljuhas
reviewed
Jan 7, 2025
pavoljuhas
approved these changes
Jan 7, 2025
daxfohl
reviewed
Jan 7, 2025
cirq-core/cirq/ops/identity_test.py
Outdated
| 1: ───I─── | ||
| │ | ||
| 2: ───I─── | ||
| """.strip() |
There was a problem hiding this comment.
cirq.testing.assert_has_diagram trims and yada yada for you.
|
If you want to solve this more broadly, I'm pretty sure the place is here: https://github.com/quantumlib/Cirq/blob/main/cirq-core/cirq/protocols/circuit_diagram_info_protocol.py#L345. Add a check |
Co-authored-by: Pavol Juhas <[email protected]>
…/Cirq-1 into identity_gate_diagram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6768