Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make errors in container image builds error and show why #54

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mdales
Copy link
Collaborator

@mdales mdales commented Jul 2, 2024

I went slightly made trying to work out what was going wrong when a pip dependancy updated and make my linter checks in my build spec fail, but shark would just swallow the error and try to build the rest of the pipeline, eventually failing when it tried to use the image it hand't successfully built.

This change:

  • Makes progress stop if an image can't be built
  • Puts in the markdown the output of the failed build

@mdales mdales merged commit 36dc033 into main Jul 2, 2024
2 checks passed
@mdales mdales deleted the mwd-make-build-errors-more-obvious branch July 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant