Fixes an issue with late close of file handles. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although in the command running loop we defer'd the close of stdout, so we technically were safe, because that was in a loop the defer wasn't closed until a lot later than necessary, and on large batches can cause ulimit to be exceeded. This fix moves the command exection to its own function which fixes the late defer, and also makes the code more easy to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although in the command running loop we defer'd the close of stdout, so we technically were safe, because that was in a loop the defer wasn't closed until a lot later than necessary, and on large batches can cause ulimit to be exceeded.
This fix moves the command exection to its own function which fixes the late defer, and also makes the code more easy to read.