Switch to leading argument order #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
There are still several instances of |
berekuk
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
This is too long to read through :)
I assume that if build and tests are passing then everything is fine. Also agree that de-naming makes sense. (Optional named arguments in Rescript are weird, it forces you to put () at the end).
Happy to see O/O2 and R/R2 being cleaned up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from
|>style to->. I've also de-named the function and scale arguments inmapYandscaleByas they're pretty obvious.scaleBy's argument being optional doesn't make much sense and causes a warning if it's put at the end.