Fix build failure with new xml-conduit release #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @nitinprakash96 I'll take a better look into it later today |
|
And it looks like bzip2 bindings got removed from the images :-\ |
|
Hi @nitinprakash96 would you mind rebasing/mering master into your branch? |
|
@nitinprakash96 already in xml-conduit-1.1.0 (the earliest supported by this library) rsPretty was False by default - https://github.com/snoyberg/xml/blob/xml-conduit/1.1.0/xml-conduit/Text/XML/Stream/Render.hs#L66 so to fix the problem we just need to drop |
|
Thanks @nitinprakash96 |
|
Released as 1.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release of xml-conduit,
RenderSettingshave been moved to anInternalmodule. Therefore, the building the package fails. It needs to importrsPrettyfrom it's new home.