Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed arm-gcc-bin to be version 10 #64

Closed
wants to merge 1 commit into from

Conversation

stealthgyro
Copy link

@stealthgyro stealthgyro commented Aug 3, 2023

The compiled firmware from MacOS when using SonixQMK on Keychrons seemed to cause an issue if too many keys were pressed or randomly the firmware appeared to just crash and flash some leds sometimes holding the last input.

Description

Updating lines in a couple repos attempting to get this squared away, as pointed out here SonixQMK/qmk_firmware#336

I'm also creating a fork and pull request on the SonixQMK Firmware https://github.com/SonixQMK/qmk_firmware will edit with that pull request.

Pull request on sonixqmkfirmware SonixQMK/qmk_firmware#345

@fauxpark
Copy link
Member

fauxpark commented Aug 3, 2023

Is there a particular reason why this change fixes your issue?

I'm planning on moving the formula away from arm-gcc-bin since it requires Rosetta on M1 Macs - although the replacement will have to be compiled locally as GitHub still does not have M1 runners to build bottles.

I was also not able to get GCC 10 built so there is only 8 and 9: osx-cross/homebrew-arm#29

@stealthgyro
Copy link
Author

That's a great question I wish I knew the answer to. perhaps a new compile method in general won't have the issue either. And to be fair what I'm doing on on the Keychron K8 (Not pro) isn't exactly supported. I was just trying to contribute back changes that helped me.

@drashna
Copy link
Member

drashna commented Aug 4, 2023

FWIW: arm gcc 10.2 causes the K8 Pro to hard lock. Or at least did, the last time I tested it. So changing the version to fix an issue is just moving around the issue and not actually fixing it.

@dexter93
Copy link

dexter93 commented Aug 4, 2023

Issue is generic on m0, see qmk/qmk_firmware#21228 (comment)

@stealthgyro
Copy link
Author

FWIW: arm gcc 10.2 causes the K8 Pro to hard lock. Or at least did, the last time I tested it. So changing the version to fix an issue is just moving around the issue and not actually fixing it.

Since it appears I was using 10.3.1 I'm curious if that issue still stands.

arm-none-eabi-gcc -v

Using built-in specs.
COLLECT_GCC=arm-none-eabi-gcc
COLLECT_LTO_WRAPPER=/opt/homebrew/Cellar/arm-none-eabi-gcc/10.3-2021.07/gcc/bin/../lib/gcc/arm-none-eabi/10.3.1/lto-wrapper
Target: arm-none-eabi
Configured with: /tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/src/gcc/configure --target=arm-none-eabi --prefix=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native --libexecdir=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/lib --infodir=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/share/doc/gcc-arm-none-eabi/info --mandir=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/share/doc/gcc-arm-none-eabi/man --htmldir=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/share/doc/gcc-arm-none-eabi/html --pdfdir=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/share/doc/gcc-arm-none-eabi/pdf --enable-languages=c,c++ --enable-plugins --disable-decimal-float --disable-libffi --disable-libgomp --disable-libmudflap --disable-libquadmath --disable-libssp --disable-libstdcxx-pch --disable-nls --disable-shared --disable-threads --disable-tls --with-gnu-as --with-gnu-ld --with-newlib --with-headers=yes --with-python-dir=share/gcc-arm-none-eabi --with-sysroot=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/install-native/arm-none-eabi --build=x86_64-apple-darwin10 --host=x86_64-apple-darwin10 --with-gmp=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/build-native/host-libs/usr --with-mpfr=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/build-native/host-libs/usr --with-mpc=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/build-native/host-libs/usr --with-isl=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/build-native/host-libs/usr --with-libelf=/tmp/jenkins-GCC-10-pipeline-259_20210727_1627345004/build-native/host-libs/usr --with-host-libstdcxx='-static-libgcc -Wl,-lstdc++ -lm' --with-pkgversion='GNU Arm Embedded Toolchain 10.3-2021.07' --with-multilib-list=rmprofile,aprofile
Thread model: single
Supported LTO compression algorithms: zlib
gcc version 10.3.1 20210621 (release) (GNU Arm Embedded Toolchain 10.3-2021.07) 

Although back to my previous statement, if arm-gcc-bin is getting dumped anyway, then all of this moot.

@fauxpark
Copy link
Member

fauxpark commented Oct 7, 2023

This is no longer applicable, the formula now uses arm-none-eabi-gcc@8.

@fauxpark fauxpark closed this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants