Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clippy version #1230

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update clippy version #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .qlty/qlty.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ version = "1.7.9"

[[plugin]]
name = "clippy"
# Note: Clippy version is controlled by the rust version above
version = "1.82.0" # Note: Clippy version is controlled by the rust version above
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out we do need this in order to make sure the version check passes after tool install.

This is needed since the latest_version defined in the plugin definition was 1.77.2 so we are expecting that when version is not defined, but bumping the rust runtime above we are basically installing 1.82.0 so version check fails.


[[plugin]]
name = "eslint"
Expand Down
4 changes: 2 additions & 2 deletions plugins/linters/clippy/plugin.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ config_version = "0"
runtime = "rust"
package = "clippy"
file_types = ["rust"]
latest_version = "1.77.2"
known_good_version = "1.77.2"
latest_version = "1.82.0"
known_good_version = "1.82.0"
config_files = ["clippy.toml", ".clippy.toml"]
affects_cache = ["Cargo.toml", "Cargo.lock"]
description = "Rust linter"
Expand Down