Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in-place upgrades and support non-curl systems #1207

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

lsegal
Copy link
Member

@lsegal lsegal commented Nov 22, 2024

Since wget is supported in the install script, do not rely on curl to download the script. Instead download via ureq.

Since wget is supported in the install script, do not rely on curl to download the script. Instead download via ureq.
Copy link
Contributor

qltysh bot commented Nov 22, 2024

The code coverage on the diff in this pull request is 0.0%

Drilldown
Path File Coverage Δ
qlty-check/src/tool/command_builder.rs 2.6
qlty-cli/src/initializer/scanner/gemfile.rs -0.3
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-check/src/tool/download.rs 0.7
qlty-check/src/tool/ruby/sys/linux.rs -1.6

@lsegal
Copy link
Member Author

lsegal commented Nov 22, 2024

Just manually tested on Windows / Linux / macOS both in and outside of ~/.qlty and they all work.

@lsegal lsegal merged commit 8bd7ee3 into main Nov 22, 2024
9 of 10 checks passed
@lsegal lsegal deleted the ls/inplace-upgrade branch November 22, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant