Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort elements going into cache keys #1198

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Sort elements going into cache keys #1198

merged 2 commits into from
Nov 21, 2024

Conversation

brynary
Copy link
Member

@brynary brynary commented Nov 21, 2024

I noticed locally that in some cases that config files were being added to the cache key in a different order, which produces different cache results. I audited the cache key generation code for iteration and added explicit sorting to try to increase determinism.

Copy link
Contributor

qltysh bot commented Nov 21, 2024

The code coverage on the diff in this pull request is 0.0%

Drilldown
Path File Coverage Δ
qlty-check/src/cache.rs -0.0
qlty-check/src/tool/command_builder.rs 2.6
qlty-config/src/library.rs -0.7
qlty-cli/src/initializer/scanner/gemfile.rs -0.3
qlty-check/src/tool/ruby/sys/macos.rs 3.1
qlty-cli/src/telemetry/segment.rs 0.0
qlty-check/src/tool/download.rs 0.7
qlty-config/src/workspace.rs -9.0
qlty-check/src/tool/ruby/sys/linux.rs -1.6
qlty-cli/src/telemetry/analytics.rs 0.0

@brynary brynary merged commit ac90714 into main Nov 21, 2024
9 of 10 checks passed
@brynary brynary deleted the bh-sort-cache-key branch November 21, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant