Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache hits for config batches #1180

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

marschattha
Copy link
Member

@marschattha marschattha commented Nov 20, 2024

If there is a driver that is batched by config with the config file in .qlty/configs directory the cache hit was being missed because the path for the config file was changed during batch computations and not reverted back to the original path of the file.

Copy link
Contributor

qltysh bot commented Nov 20, 2024

The code coverage on the diff in this pull request is 98.6%

Drilldown
Path File Coverage Δ
qlty-check/src/tool/command_builder.rs -2.6
qlty-config/src/library.rs 0.7
qlty-cli/src/telemetry/sanitize.rs 0.2
qlty-cli/src/initializer/scanner/gemfile.rs 0.3
qlty-check/src/tool/ruby/sys/macos.rs -3.1
qlty-check/src/tool/download.rs -0.7
qlty-check/src/tool/ruby/sys/linux.rs 1.6
qlty-check/src/planner/target_batcher.rs -0.2

@marschattha marschattha requested a review from brynary November 20, 2024 17:06
@marschattha marschattha force-pushed the ma/fix_cache_hits_for_config_batches branch from c8159c7 to c2a9a4b Compare November 20, 2024 17:11
@brynary
Copy link
Member

brynary commented Nov 20, 2024

@marschattha I don't have any reason to believe this should not work, however modifying the path and then modifying it back strikes me as a bit messy.

How could we approach this in a way which doesn't require that?

@brynary brynary requested a review from lsegal November 21, 2024 01:36
@brynary
Copy link
Member

brynary commented Nov 21, 2024

Tagged @lsegal in case he has any feedback. In the meantime, going to merge this now to cut a release, since this is a significant performance regression.

@brynary brynary merged commit 6343eb8 into main Nov 21, 2024
8 checks passed
@brynary brynary deleted the ma/fix_cache_hits_for_config_batches branch November 21, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants