Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci lint suggestions #1145

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add golangci lint suggestions #1145

merged 2 commits into from
Nov 18, 2024

Conversation

marschattha
Copy link
Member

No description provided.

@marschattha marschattha requested a review from brynary November 18, 2024 19:40
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marschattha marschattha force-pushed the ma/add_golang_ci_parser branch from bc52196 to 20ee268 Compare November 18, 2024 19:57
@qltysh qltysh
Copy link
Contributor

qltysh bot commented Nov 18, 2024 •
edited
Loading

The code coverage on the diff in this pull request is 99.2%

Drilldown
Path File Coverage Δ
qlty-check/src/patch_builder.rs 0.3
qlty-check/src/executor/driver.rs -0.1
qlty-check/src/parser/golangci_lint.rs 99.7

@marschattha marschattha merged commit ac0058b into main Nov 18, 2024
8 checks passed
@marschattha marschattha deleted the ma/add_golang_ci_parser branch November 18, 2024 22:20
@marschattha marschattha mentioned this pull request Nov 19, 2024
Merged
marschattha added a commit that referenced this pull request Nov 19, 2024
@marschattha
Update Golangci parser to handle delete only suggestions (#1155)
517355c 
Fix for missing case in #1145
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynary brynary brynary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marschattha @CLAassistant @brynary