Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct result shape for non-multiplexed firmwares #127

Merged
merged 3 commits into from
Sep 14, 2024

Conversation

rodolfocarobene
Copy link
Contributor

Fixes #125

Checklist before merge:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Documentation is updated.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.00%. Comparing base (f516938) to head (87ac72c).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/qibosoq/programs/sweepers.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   93.96%   94.00%   +0.04%     
==========================================
  Files          12       12              
  Lines         729      734       +5     
==========================================
+ Hits          685      690       +5     
  Misses         44       44              
Flag Coverage Δ
unittests 94.00% <96.29%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodolfocarobene rodolfocarobene marked this pull request as ready for review August 29, 2024 10:07
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reread the changes, and it seems alright. Did you manage to run?

@rodolfocarobene rodolfocarobene merged commit 09a8516 into main Sep 14, 2024
31 checks passed
@rodolfocarobene rodolfocarobene deleted the fix_collect_shots branch September 14, 2024 09:35
@alecandido
Copy link
Member

@scarrazza we may need another release for this bugfix

@scarrazza
Copy link
Member

Shall we go for a new release now?

@alecandido
Copy link
Member

I'm fine with doing it now (I can even make it myself, as you prefer).

@rodolfocarobene?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error appears doing Rabi
3 participants