-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in report template #1060
base: 0.2
Are you sure you want to change the base?
Conversation
693fdf1
to
bb9b084
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1060 +/- ##
==========================================
- Coverage 96.96% 96.95% -0.02%
==========================================
Files 98 98
Lines 7932 7935 +3
==========================================
+ Hits 7691 7693 +2
- Misses 241 242 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -46,10 +53,10 @@ | |||
<ul class="list-unstyled ps-0"> | |||
{% if report %} | |||
<li class="mb-1"> | |||
<buttom class="btn btn-toggle d-inline-flex align-items-center rounded border-0" data-bs-toggle="collapse" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice...
Since this PR is changing the template, I would suggest adding a button to display/download the runcard (if there is) and another one for the new |
Given that they are just served at URLs with a fixed relative path, it should be fairly simple. |
Done in 848e31c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks nice. Thanks @andrea-pasquale !
A few improvements to the qibocal report template:
href