Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in report template #1060

Open
wants to merge 6 commits into
base: 0.2
Choose a base branch
from
Open

Improvements in report template #1060

wants to merge 6 commits into from

Conversation

andrea-pasquale
Copy link
Contributor

A few improvements to the qibocal report template:

  • Fix some href
  • Add GitHub logo pointing to qibocal repo
  • Add targets in navbar
  • Refactor layout of table with versions

@andrea-pasquale andrea-pasquale marked this pull request as draft January 10, 2025 09:36
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (9723091) to head (d48add9).
Report is 19 commits behind head on 0.2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              0.2    #1060      +/-   ##
==========================================
- Coverage   96.96%   96.95%   -0.02%     
==========================================
  Files          98       98              
  Lines        7932     7935       +3     
==========================================
+ Hits         7691     7693       +2     
- Misses        241      242       +1     
Flag Coverage Δ
unittests 96.95% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/cli/report.py 100.00% <100.00%> (ø)
src/qibocal/web/report.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@andrea-pasquale andrea-pasquale marked this pull request as ready for review January 15, 2025 07:54
@@ -46,10 +53,10 @@
<ul class="list-unstyled ps-0">
{% if report %}
<li class="mb-1">
<buttom class="btn btn-toggle d-inline-flex align-items-center rounded border-0" data-bs-toggle="collapse"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice...

@Edoardo-Pedicillo
Copy link
Contributor

Edoardo-Pedicillo commented Jan 23, 2025

Since this PR is changing the template, I would suggest adding a button to display/download the runcard (if there is) and another one for the new parameters.json. (Feel free to ignore the message or move in a issue)

@alecandido
Copy link
Member

Since this PR is changing the template, I would suggest adding a button to display/download the runcard (if there is) and another one for the new parameters.json. (Feel free to ignore the message or move in a issue)

Given that they are just served at URLs with a fixed relative path, it should be fairly simple.
It truly consists in adding some text/box/button within an anchor element with the given href (relative ./).
All the time-consuming part is deciding the appearance and placement of the element.

@andrea-pasquale
Copy link
Contributor Author

Since this PR is changing the template, I would suggest adding a button to display/download the runcard (if there is) and another one for the new parameters.json. (Feel free to ignore the message or move in a issue)

Done in 848e31c.
Currently if the report is generated by a script the runcard button will generate an error "File not found", which can be improved I guess.

Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice. Thanks @andrea-pasquale !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants