Raising errors for missing M or nshots

[BrunoLiegiBastonLiegi]

As per title, errors are raised when running on hardware and either:

• no measurements are present in the circuit
• nshots is not defined

this should close #73

At the moment I am just checking whether device == "k2", but ideally it would be nice if each partition had a property, simulation=True for instance, doing the check on the node inside the job and returning an error response.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ea1e2f) to head (4c7aa4e).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #81   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          232       232           
=========================================
  Hits           232       232           

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[scarrazza]

Okay, that is a good point in favor of moving this check to the front end. @marcorossi5, could you please show @BrunoLiegiBastonLiegi how to change the front-end API and include this feature?

[marcorossi5]

Moving the logic to the webapp means adding the checks in this function: https://github.com/qiboteam/qibo-webapp/blob/892ee98d36d777873a1c713d3c92b8beade19cd6/src/client/views.py#L75

New tests go in this class: https://github.com/qiboteam/qibo-webapp/blob/892ee98d36d777873a1c713d3c92b8beade19cd6/src/client/tests/test_views.py#L27

[BrunoLiegiBastonLiegi]

Now that qiboteam/qibo-webapp#105 implemented the blocking of circuit without measurements or nshots specified, this PR probably reduces to just some minor additions to the docstrings, and setting nshots=None by default. I am not sure whether we are supposed to test here as well that run_circuit returns a 403 response in those cases.

[scarrazza]

Thanks @BrunoLiegiBastonLiegi . I think we should make the device mandatory (i.e. remove the default value).

[scarrazza]

Thanks @BrunoLiegiBastonLiegi, could you please double check if the README and sphinx docs are okay with your latest changes?

[BrunoLiegiBastonLiegi]

The README is showing an example with the sim partition (btw, this should be changed to k2 now, right?), thus it should be fine. The docs at the moment seem to consist in basically just the dosctrings from the source code, which I modified already, so nothing to do there as well.

[scarrazza]

Thanks, I would suggest to do not state any device name here and just point to the user that in order to device the device name, visit the cloud system and checkout the available partitions for his account.