Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show sip.wrapper as base class, just show object #152

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Don't show sip.wrapper as base class, just show object #152

merged 1 commit into from
Aug 6, 2024

Conversation

nyalldawson
Copy link
Contributor

Fixes #16

3nids
3nids reviewed Aug 6, 2024
View reviewed changes
process_links.py
@@ -31,20 +31,6 @@
)


def show_inheritance(obj):
# handle inheritance printing to patch qgis._core with qgis.core
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3nids doesn't seem to be. I get the same result without it. Maybe it's related to moving this logic...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool then

@3nids 3nids merged commit 93fb247 into qgis:main Aug 6, 2024
4 checks passed
@nyalldawson nyalldawson deleted the no_wrapper branch August 7, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids 3nids left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove "sip.wrapper" from base class list
2 participants
@nyalldawson @3nids