Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DXF] Fix writing the codec name and set the correct DXF version (Fix #60802) #60814

Merged
merged 4 commits into from
Mar 2, 2025
Merged

[DXF] Fix writing the codec name and set the correct DXF version (Fix #60802) #60814

merged 4 commits into from
Mar 2, 2025

Conversation

agiudiceandrea
Copy link
Member

@agiudiceandrea agiudiceandrea commented Mar 1, 2025 •
edited
Loading

Description

This PR

  • ensures the codec name is written in the exported DXF file (on some systems, like Windows / OSGeo4W, some codecs' names were not written due to case mismatch)
  • sets $ACADVER to AC1018 (AutoCAD 2004) because codes 420 and 440 (which are written in the DXF file by QgsDxfEport) are listed in DXF specs only since AutoCAD 2004

Fixes #60802.

@agiudiceandrea
[DXF] Fix writing encoding name
9d73304
@agiudiceandrea
[DXF] Avoid a loop in dxfEncoding
f56bfa9 
and make it case insensitive
@agiudiceandrea
[DXF] Add test for codepage writing
1f76ece
@agiudiceandrea
[DXF] Set $ACADVER to AC1018 (AutoCAD 2004)
fa7d1e0 
because codes 420 and 440 (which are written in the DXF file by QgsDxfEport) are listed in DXF specs only since AutoCAD 2004
@agiudiceandrea agiudiceandrea added DXF/DWG Relating to DXF or DWG importing/exporting Bug Either a bug report, or a bug fix. Let's hope for the latter! backport queued_ltr_backports Queued Backports backport release-3_42 labels Mar 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit fa7d1e0)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit fa7d1e0)

@lbartoletti lbartoletti merged commit 1b40a30 into qgis:master Mar 2, 2025
52 checks passed
This was referenced Mar 2, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbartoletti lbartoletti lbartoletti approved these changes

Assignees
No one assigned
Labels
backport queued_ltr_backports Queued Backports backport release-3_42 Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exported DXF - header has incorrect version ACADVER AC1015 and sometimes lacks encoding DWGCODEPAGE
2 participants
@agiudiceandrea @lbartoletti