[oauth2] Allow for extra OAuth2 token(s) to be added into the headers #60668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nirvn
force-pushed
the
oauth2_extra_tokens
branch
from
7846e01 to
ffc6c07
Compare
m-kuhn
approved these changes
Feb 24, 2025
|
@nirvn I find the UI here a little unclear -- in my initial reading I thought the token would be the key name and the second column a hardcoded value to set. But it seems that the first column is just a arbitrary user-set identifier? Could we do away with that identifier and just use a list for the header keys instead? |
m-kuhn
reviewed
Feb 25, 2025
nyalldawson
reviewed
Feb 25, 2025
nirvn
force-pushed
the
oauth2_extra_tokens
branch
from
ffc6c07 to
80b739b
Compare
|
@nyalldawson , comments addressed, thanks. |
nyalldawson
approved these changes
Mar 3, 2025
|
Thanks for the flexibility @nirvn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an oauth2 advanced configuration option to attach extra tokens sent by the OAuth2 token endpoint as HTTP(S) request headers. The UI looks as follow:
This can be quite useful when working with OAuth2 service providers such as Google which adds openid tokens to their token replies.