Fix pasting unsaved changes as temporary scratch layers #60474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @uclaros |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Aha! This makes sense :) Maybe also extend |
nyalldawson
force-pushed
the
fix_38913
branch
2 times, most recently
from
feba1d8 to
011c141
Compare
Instead of a string value of the default value clause (eg "Autonumber"), initialize the attribute to a QgsUnsetValueAttribute Refs qgis#38913
… attribute values
This provider check has non-standard default values set for the source table
nyalldawson
force-pushed
the
fix_38913
branch
from
011c141 to
5fc13f9
Compare
nyalldawson
force-pushed
the
fix_38913
branch
from
1cf4ffd to
b7223cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix to #57985, which fixes the underlying issue.
I think these changes are too risky to merge for 3.42.0, so I propose holding them off till 3.44 (and temporarily including #57985 as a fix in the meantime)