Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport queued_ltr_backports] Fix WMS layer access control check #58529

Closed
wants to merge 4 commits into from
Closed

[Backport queued_ltr_backports] Fix WMS layer access control check #58529

wants to merge 4 commits into from

Conversation

qgis-bot
Copy link
Collaborator

Backport #58073
Authored by: @dmarteau

@github-actions github-actions bot added this to the 3.40.0 milestone Aug 29, 2024
@rldhont rldhont added the Server Related to QGIS server label Aug 29, 2024
@dmarteau @rldhont
Fix 'unused parameter' error
46693c6 
    Fix 'unused parameter' error when compiling without
    HAVE_SERVER_PYTHON_PLUGINS defined
@rldhont rldhont mentioned this pull request Sep 5, 2024
Merged
@rldhont
Copy link
Contributor

rldhont commented Sep 6, 2024

It is a fix ready for merging @elpaso or @pblottiere or @mhugent

@rldhont rldhont requested a review from elpaso September 11, 2024 13:20
@rldhont
Copy link
Contributor

rldhont commented Sep 13, 2024

gentle ping @elpaso or @pblottiere or @mhugent

@rldhont
Copy link
Contributor

rldhont commented Sep 13, 2024

@elpaso I have added the const to allowed like in #58530

@nyalldawson nyalldawson force-pushed the queued_ltr_backports branch 2 times, most recently from fddfee5 to 50e3acf Compare September 14, 2024 03:25
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 29, 2024
@rldhont
Copy link
Contributor

rldhont commented Sep 30, 2024

@elpaso can it be merged queued_ltr_backports ? The fix is already in master and 3.38.

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 30, 2024
@rldhont
Copy link
Contributor

rldhont commented Oct 1, 2024

I close the backport, because we found unnecessary call to the function checkLayerReadPermissions

@rldhont rldhont closed this Oct 1, 2024
@agiudiceandrea agiudiceandrea deleted the backport-58073-to-queued_ltr_backports branch February 17, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont left review comments

@elpaso elpaso Awaiting requested review from elpaso

Assignees
No one assigned
Labels
Server Related to QGIS server
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
4 participants
@qgis-bot @rldhont @DelazJ @dmarteau