[Backport queued_ltr_backports] Fix bug with inverted polygon renderer vs OTF simplification #58480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simplification MUST be applied prior to transforming geometries, or the precalculated simplification tolerance will no be correct and may be excessive (eg when the simplification tolerance was calculated for a map in meters, yet the rendered layer is in degrees -- in this case we would simplify the inverted geometry with a tolerance of ~1 degree!) Ensure that we apply the simplification FIRST, then transform, and disable further simplification when rendering the calculated inverted feature. This is also a performance boost, because we are simplifying geometries prior to transforming + calculating the inversion, so usually end up with a lot less vertices to handle in those operations...
nyalldawson
reviewed
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #58471
Authored by: @nyalldawson