-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show notes for algs which regenerate primary keys #58100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new Qgis::ProcessingAlgorithmDocumentationFlag flag, with a virtual method in QgsProcessingAlgorithm to return documentation flags. These flags are used to indicate algorithm behavior which should be noted in the documentation. Add initial flags for algorithms which drop and regenerate primary keys/FIDs, and automatically add a note to the algorithm's help panel to explain that this will occur In future this flag could be extended with other helpful warnings, eg - Algorithm requires valid geometries - Algorithm will segmentize curved geometries - Algorithm will drop Z or M values
nyalldawson
commented
Jul 14, 2024
Another potential flag would be "uses ellipsoidal calculations for area/length measurements" |
lbartoletti
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Qgis::ProcessingAlgorithmDocumentationFlag flag, with a virtual method in QgsProcessingAlgorithm to return documentation flags. These flags are used to indicate algorithm behavior which should be noted in the documentation.
Add initial flags for algorithms which drop and regenerate primary keys/FIDs, and automatically add a note to the algorithm's help panel to explain that this will occur
In future this flag could be extended with other helpful warnings, eg