[relations] Fix problematic polymorphic relation's generated relation IDs #57792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
polymorphicrelation_generated_id_fix
branch
from
57e68e0 to
5b61e2e
Compare
m-kuhn
reviewed
Jun 19, 2024
m-kuhn
reviewed
Jun 19, 2024
m-kuhn
approved these changes
Jun 19, 2024
nirvn
force-pushed
the
polymorphicrelation_generated_id_fix
branch
from
5b61e2e to
73c4282
Compare
|
@m-kuhn , thanks for the review, comments added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #47445 by insuring that polymorphic relations' generated relations rely on generated IDs that will remain valid if users change the referenced layer name.
To avoid breaking preexisting projects, relations using the weaker IDs (using layer name instead of layer ID) are also generated with a (deprecated) suffix added to their names. A //TODO is added to remove this whenever we hop onto QGIS 4 where we can break things ;)The relation ID is automatically updated by the relation manager, insuring projects saved prior to this change don't break.I'd suggest backporting to LTR, IMHO a worthy fix. Among other things, it allows for polymorphic relationships to not go broken with translated projects.