Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group name to processing algorithm dialog title #57739

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Jun 12, 2024

Description

This shows the group from which a processing algorithm originates in the dialog title. This makes it easier to understand for a user, from where an algorithm is coming.

Context: The current "unqualified" dialog title was leading to confusion in a course yesterday where some people where opening the "Point Cloud - Clip" algorithm whereas they meant to use "Vector Layer - Clip" algorithm.

New:

image

Old:

image

@github-actions github-actions bot added this to the 3.38.0 milestone Jun 12, 2024
@m-kuhn m-kuhn changed the title Add group name to processing algorithm title Add group name to processing algorithm dialog title Jun 12, 2024
@m-kuhn m-kuhn added the backport queued_ltr_backports Queued Backports label Jun 12, 2024
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 33fd91c)

@m-kuhn m-kuhn merged commit 4d07482 into qgis:master Jun 12, 2024
34 checks passed
@m-kuhn m-kuhn deleted the processing_alg_dialog_context branch June 12, 2024 12:39
@agiudiceandrea
Copy link
Member

@DelazJ, do some screenshots in the docs need to be updated?

@DelazJ
Copy link
Contributor

DelazJ commented Jul 3, 2024

@agiudiceandrea yes in the Processing framework chapter and a number of training lessons. Do you suggest to add this to the docs issues queue?

@agiudiceandrea
Copy link
Member

I think so, so someone could take care of the small changes at least in https://docs.qgis.org/testing/en/docs/user_manual/processing/toolbox.html#the-algorithm-dialog

@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Jul 3, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Jul 3, 2024

@m-kuhn
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Jul 3, 2024

@m-kuhn
A documentation ticket has been opened at qgis/QGIS-Documentation#9157
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@DelazJ
Copy link
Contributor

DelazJ commented Aug 27, 2024

@m-kuhn any reason why this feature wasn't extended to modeler context?

@m-kuhn
Copy link
Member Author

m-kuhn commented Aug 27, 2024

No reason beyond: I wasn't aware that it should have been added somewhere else.
Can you open a follow up pull request or do you want to tell me where it should be?

@DelazJ
Copy link
Contributor

DelazJ commented Aug 27, 2024

See #58502 (hopefully I got it right)

@kannes
Copy link
Contributor

kannes commented Aug 27, 2024

oooh nice, this was always a huge problem with models.

@qgis-bot
Copy link
Collaborator

The backport to release-3_38 failed:

The process '/usr/bin/git' failed with exit code 1
stderr
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

    git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

stdout
On branch backport-57739-to-release-3_38
You are currently cherry-picking commit 33fd91c385d.
  (all conflicts fixed: run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

nothing to commit, working tree clean

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_38 release-3_38
# Navigate to the new working tree
cd .worktrees/backport-release-3_38
# Create a new branch
git switch --create backport-57739-to-release-3_38
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 33fd91c385ddbb07f8b92c917d6d1c84fd444b85
# Push it to GitHub
git push --set-upstream origin backport-57739-to-release-3_38
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_38

Then, create a pull request where the base branch is release-3_38 and the compare/head branch is backport-57739-to-release-3_38.

@qgis-bot qgis-bot added the failed backport The automated backport attempt failed, needs a manual backport label Aug 28, 2024
@DelazJ
Copy link
Contributor

DelazJ commented Aug 28, 2024

Oups this was added in the 3.8 dev cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport queued_ltr_backports Queued Backports failed backport The automated backport attempt failed, needs a manual backport Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants