-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectiveMasking] install masks for QgsTemplatedLineSymbolLayer #57694
Conversation
5ec09de
to
9a11e4f
Compare
@troopa81 to fix the test/segfault here i'd suggest using the SafePainter class from https://github.com/qgis/QGIS/blob/master/tests/src/python/test_qgsgeometrypaintdevice.py#L45 instead of raw painters throughout the selective masking test class. That should allow the test to exit gracefully and write out the full test report instead of just crashing when a failure occurs. |
this test (and almost all selective masking tests) don't use QPainter directly and use QgsLayoutExporter to generate PDF. |
f5b7a8d
to
311c0c9
Compare
80fcbc2
to
bcea99e
Compare
unrelated test failure, segmentation faut has been fixed. @nyalldawson Do you mind merging? |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-57694-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick c73f4ff1ef18b46151ace919617e75d04862f2d6,ece791c24d69b5db69f78417702ac3e12dcdedb0,6d60df04abf479b8ed4bc5d2894fd5f2d1b689a6,58a8b3634e79cc7b95287dc6818545b38b38e9c0,bcea99e3309676ae96720316ab5618bd6a7bb6af
# Push it to GitHub
git push --set-upstream origin backport-57694-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
Fixes #57564