-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PostgreSQL compound key discovery #57653
Conversation
Tests for relation discovery seem to exist but are based on referenced keys being first attributes of the referenced table. I'm going to update that one. To run:
|
7f42ebf
to
2e48ab9
Compare
900f985
to
fa951bc
Compare
The test did nothing References qgisGH-56420
fa951bc
to
4554b97
Compare
I've pushed a change in existing testcase to basically list the referenced columns in the inverse order in which they were defined. This triggers the bug reported in GH-56420 To show the CI catching the bug I've currently also pushed a revert of the fix, to expect a failure. Once the failure is shown, I'll drop the revert and leave the fix in place to see how that fixes the problem. |
Bug confirmed by CI: https://github.com/qgis/QGIS/actions/runs/9446127636/job/26016503531?pr=57653#step:13:2257 |
References qgisGH-56420 exposing the bug reported there
4554b97
to
c70936b
Compare
Tests failed for Qt 5One or more tests failed using the build from commit 847ef3e layout_export_markerline_masked_geometrylayout_export_markerline_masked_geometryTest failed at test_markerline_masked at tests/src/python/test_selective_masking.py:1376 Rendered image did not match tests/testdata/control_images/selective_masking/layout_export_markerline_masked/layout_export_markerline_masked.png (found 124 pixels different) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
Closes GH-56420