If password keychain helper is enabled, always sync password stored in keychain when password is changed #55227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitdm-oslandia
added
Authentication
github-actions
bot
added
the
stale
Why's this not merged? |
github-actions
bot
removed
the
stale
nyalldawson
force-pushed
the
always_sync
branch
3 times, most recently
from
843be53 to
c5479cd
Compare
|
@elpaso Ok this has been rebased and updated based on our discussion. Here's what the reset password dialog looks like now (if system wallet integration is enabled):
|
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
LGTM! |
nyalldawson
force-pushed
the
always_sync
branch
from
fe001a9 to
16692aa
Compare
elpaso
approved these changes
Feb 6, 2025
stored in keychain when password is changed This used to be a separate menu action that the user had to remember to run. Let's err on the side of being helpful and assume that if the user is storing the password in their keychain, then they want that stored password always to be the correct one.
When resetting the master password and wallet storage is enabled, tweak the reset password dialog label to explicitly state that the new password will be stored in the wallet. This keeps users fully advised of what's about to occur.
nyalldawson
force-pushed
the
always_sync
branch
from
9377d0d to
70ea5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be a separate menu action that the user had to remember to run. Let's err on the side of being helpful and assume that if the user is storing the password in their keychain, then they want that stored password always to be the correct one.